Browse Source

MoonchildProductions#1251 - Part 10: ipc_channel_posix.cc should use IOV_MAX.

https://bugzilla.mozilla.org/show_bug.cgi?id=1345102

I assess this change to be low-risk for the following reasons:

1. It has been in Firefox since version 55 without issues.

2. The current behavior is not POSIX compliant, and is retained in the one instance where the new functionality causes issues.

3. It makes safer assumptions about implementation details than what we have now.
pull/24/head
athenian200 2 years ago
committed by Roy Tam
parent
commit
9df21e3a0e
  1. 11
      ipc/chromium/src/chrome/common/ipc_channel_posix.cc

11
ipc/chromium/src/chrome/common/ipc_channel_posix.cc

@ -8,6 +8,7 @@
#include <errno.h>
#include <fcntl.h>
#include <limits.h>
#if defined(OS_MACOSX)
#include <sched.h>
#endif
@ -39,8 +40,16 @@
#include "mozilla/ipc/Faulty.h"
#endif
// Work around possible OS limitations.
// Use OS specific iovec array limit where it's possible
#if defined(IOV_MAX)
static const size_t kMaxIOVecSize = IOV_MAX;
// IOV_MAX isn't defined on Android, but the hard-coded 256 works well.
#elif defined(ANDROID)
static const size_t kMaxIOVecSize = 256;
// On all other platforms, fallback to 16 (_XOPEN_IOV_MAX) as a safe bet.
#else
static const size_t kMaxIOVecSize = 16;
#endif
#ifdef MOZ_TASK_TRACER
#include "GeckoTaskTracerImpl.h"

Loading…
Cancel
Save