import changes from `dev' branch of rmottola/Arctic-Fox:

- Bug 1166847 followup: Add 'override' annotation to some new overriding methods in jswrapper.h. rs=ehsan (20a3e9857)
- pointer style (b13f08224)
- Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj (c8fa9e836)
- Bug 1156398: Pass ProcessOrientation.cpp's unused-by-default bools to mozilla::unused. r=mwu (e1200be54)
- Bug 1159124 - Suppress -Wunused-exception-parameter warning in nsClipboard.mm. r=spohl (dc3c4c4d0)
- Bug 1152921 - Always initialize platform-specific booleans in PrintData before sending over IPC. r=mconley (45fb8cf07)
- Bug 1091112 - Serialize nsIPrintSettings options bitfield. r=jimm (17d38b152)
- Bug 1091112 - Add OS X-specific members to PrintData IPDL struct. r=jimm (62182eb24)
- Bug 1091112 - Proxy opening the print dialog on OS X to the parent. r=mstange (adf38a12a)
- Bug 1204398 - Fix -Wshadow warnings in widget/cocoa. r=spohl (9c4f43861)
- missing bits of Bug 1193038: Purposely leak StatisticsReport object and suppress the leak report r=glandium,mccr8,njn (cc0c1a908)
- Bug 1144580 - Whitelist pselect6 in content seccomp-bpf policy. r=kang (144c67d00)
- Bug 1144514 - Whitelist pread64 in content seccomp-bpf policy. r=kang (c01f7f65c)
- Bug 1055310 - Step 1: Convert seccomp-bpf policies to Chromium PolicyCompiler. r=kang (8fbf648ba)
- Bug 1055310 - Step 2: Move SIGSYS handling to Chromium TrapRegistry. r=kang (e80ff13a6)
- Bug 1055310 - Step 3: Move syscall interceptions into SandboxFilter.cpp. r=kang (59c0b2454)
- Bug 1004011 - Support SECCOMP_FILTER_FLAG_TSYNC if available. r=kang (cf97070a9)
- Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium. (c9df97498)
- Bug 1189125 - Allow xpcshell to use GTK (r=karlt) (e363a27aa)
- Bug 830801 - Part 1. Set NOMINMAX define as default. r=mshal (88fa52e9e)
- Bug 830801 - Part 3. Remove NOMINMAX define from cpp source. r=mshal (c841b399f)
- Bug 1169433 - Remove UnicharSelfTest and turn NormalizationTest into a gtest. r=glandium,smontagu (625dcaf32)
- Bug 1170072 - Part 1. Make GetCharProps1 as static function. r=jfkthame (6ab8b7c4f)
- Bug 1183209 patch 2: update data generation tools to Unicode 8, r=jfkthame (78e91de20)
- Bug 1183209 patch 3: update generated data files to Unicode 8, and adapt internal XIDMOD types to the new types in Unicode's xidmodifications.txt, r=jfkthame (c9fea054f)

accessible/atk/moz.build

@@ -55,5 +55,3 @@ include('/ipc/chromium/chromium-config.mozbuild')
 if CONFIG['CLANG_CXX']:
     # Suppress clang warning about unused function from gobject's RTTI macros.
     CXXFLAGS += ['-Wno-unused-function']
-
-FAIL_ON_WARNINGS = True

accessible/base/moz.build

@@ -97,5 +97,3 @@ if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/generic/moz.build

@@ -57,5 +57,3 @@ else:
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/html/moz.build

@@ -43,5 +43,3 @@ else:
     ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/ipc/moz.build

@@ -47,5 +47,3 @@ if CONFIG['ACCESSIBILITY']:
     FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/mac/moz.build

@@ -40,5 +40,3 @@ LOCAL_INCLUDES += [
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/other/moz.build

@@ -22,5 +22,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/windows/ia2/moz.build

@@ -52,6 +52,4 @@ FINAL_LIBRARY = 'xul'
 if CONFIG['OS_ARCH'] == 'WINNT':
     DEFINES['NOMINMAX'] = True
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')

accessible/windows/msaa/moz.build

@@ -60,5 +60,3 @@ LOCAL_INCLUDES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/windows/sdn/moz.build

@@ -24,5 +24,3 @@ LOCAL_INCLUDES += [
 DEFINES['NOMINMAX'] = True
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/windows/uia/moz.build

@@ -23,5 +23,3 @@ FINAL_LIBRARY = 'xul'
 # macros which conflicts with std::min/max.  Suppress the macros:
 if CONFIG['OS_ARCH'] == 'WINNT':
     DEFINES['NOMINMAX'] = True
-
-FAIL_ON_WARNINGS = True

accessible/xpcom/moz.build

@@ -48,5 +48,5 @@ else:
 
 FINAL_LIBRARY = 'xul'
 
-if CONFIG['GNU_CXX']:
-    FAIL_ON_WARNINGS = True
+if not CONFIG['GNU_CXX']:
+    ALLOW_COMPILER_WARNINGS = True

accessible/xul/moz.build

@@ -48,5 +48,3 @@ else:
     ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

b2g/app/moz.build

@@ -75,8 +75,6 @@ if CONFIG['OS_ARCH'] == 'WINNT':
         'version',
     ]
 
-FAIL_ON_WARNINGS = True
-
 JS_PREFERENCE_FILES += [
     'b2g.js',
 ]

b2g/dev/config/mozconfigs/macosx64/mulet

@@ -15,7 +15,7 @@ export MOZILLA_OFFICIAL=1
 
 ac_add_options --with-macbundlename-prefix=Firefox
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

b2g/gaia/moz.build

@@ -18,5 +18,3 @@ else:
     ]
     DEFINES['B2G_NAME'] = '"%s-bin%s"' % (PROGRAM, CONFIG['BIN_SUFFIX'])
     DEFINES['GAIA_PATH'] = '"gaia/profile"'
-
-FAIL_ON_WARNINGS = True

browser/components/feeds/moz.build

@@ -36,4 +36,5 @@ LOCAL_INCLUDES += [
     '../build',
 ]
 
-FAIL_ON_WARNINGS = True
+with Files('**'):
+    BUG_COMPONENT = ('Firefox', 'RSS Discovery and Preview')

browser/components/migration/moz.build

@@ -51,3 +51,5 @@ EXTRA_PP_JS_MODULES += [
 
 FINAL_LIBRARY = 'browsercomps'
 
+with Files('**'):
+    BUG_COMPONENT = ('Firefox', 'Migration')

browser/components/shell/moz.build

@@ -46,3 +46,6 @@ for var in ('MOZ_APP_NAME', 'MOZ_APP_VERSION'):
     DEFINES[var] = '"%s"' % CONFIG[var]
 
 CXXFLAGS += CONFIG['TK_CFLAGS']
+
+with Files('**'):
+    BUG_COMPONENT = ('Firefox', 'Shell Integration')

browser/config/mozconfigs/linux32/common-opt

@@ -12,7 +12,7 @@ ac_add_options --enable-stdcxx-compat
 # Needed to enable breakpad in application.ini
 export MOZILLA_OFFICIAL=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux32/debug

@@ -13,7 +13,7 @@ export MOZILLA_OFFICIAL=1
 #Use ccache
 ac_add_options --with-ccache=/usr/bin/ccache
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux64/common-opt

@@ -12,7 +12,7 @@ ac_add_options --enable-stdcxx-compat
 # Needed to enable breakpad in application.ini
 export MOZILLA_OFFICIAL=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux64/debug

@@ -13,7 +13,7 @@ export MOZILLA_OFFICIAL=1
 # Use ccache
 ac_add_options --with-ccache=/usr/bin/ccache
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/macosx-universal/common-opt

@@ -12,7 +12,7 @@ ac_add_options --with-google-api-keyfile=/builds/gapi.data
 # Needed to enable breakpad in application.ini
 export MOZILLA_OFFICIAL=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/macosx64/debug

@@ -10,7 +10,7 @@ export MOZILLA_OFFICIAL=1
 
 ac_add_options --with-macbundlename-prefix=Firefox
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/win32/common-opt

@@ -26,7 +26,7 @@ else
   . $topsrcdir/build/win32/mozconfig.vs2010
 fi
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/win32/debug

@@ -17,7 +17,7 @@ else
   . $topsrcdir/build/win32/mozconfig.vs2010
 fi
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/win64/debug

@@ -14,6 +14,9 @@ if test -z "${_PYMAKE}"; then
   mk_add_options MOZ_MAKE_FLAGS=-j1
 fi
 
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
+ac_add_options --enable-warnings-as-errors
+
 # Package js shell.
 export MOZ_PACKAGE_JSSHELL=1
 

build/stlport/moz.build

@@ -69,3 +69,5 @@ if CONFIG['GNU_CXX']:
 # Force to build a static library, instead of a fake library, without
 # installing it in dist/lib.
 NO_EXPAND_LIBS = True
+
+ALLOW_COMPILER_WARNINGS = True

caps/moz.build

@@ -51,5 +51,3 @@ LOCAL_INCLUDES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

chrome/moz.build

@@ -40,5 +40,3 @@ LOCAL_INCLUDES += [
 
 if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['TK_CFLAGS']
-
-FAIL_ON_WARNINGS = True

config/config.mk

@@ -382,25 +382,27 @@ endif # CROSS_COMPILE
 CFLAGS += $(MOZ_FRAMEPTR_FLAGS)
 CXXFLAGS += $(MOZ_FRAMEPTR_FLAGS)
 
-# Check for FAIL_ON_WARNINGS (Shorthand for Makefiles to request that we use
-# the 'warnings as errors' compile flags)
+# Check for ALLOW_COMPILER_WARNINGS (shorthand for Makefiles to request that we
+# *don't* use the warnings-as-errors compile flags)
 
-# NOTE: First, we clear FAIL_ON_WARNINGS[_DEBUG] if we're doing a Windows PGO
-# build, since WARNINGS_AS_ERRORS has been suspected of causing isuses in that
-# situation. (See bug 437002.)
+# Don't use warnings-as-errors in Windows PGO builds because it is suspected of
+# causing problems in that situation. (See bug 437002.)
 ifeq (WINNT_1,$(OS_ARCH)_$(MOZ_PROFILE_GENERATE)$(MOZ_PROFILE_USE))
-FAIL_ON_WARNINGS=
+ALLOW_COMPILER_WARNINGS=1
 endif # WINNT && (MOS_PROFILE_GENERATE ^ MOZ_PROFILE_USE)
 
-# Check for normal version of flag, and add WARNINGS_AS_ERRORS if it's set to 1.
-ifdef FAIL_ON_WARNINGS
-# Never treat warnings as errors in clang-cl, because it warns about many more
+# Don't use warnings-as-errors in clang-cl because it warns about many more
 # things than MSVC does.
-ifndef CLANG_CL
+ifdef CLANG_CL
+ALLOW_COMPILER_WARNINGS=1
+endif # CLANG_CL
+
+# Use warnings-as-errors if ALLOW_COMPILER_WARNINGS is not set to 1 (which
+# includes the case where it's undefined).
+ifneq (1,$(ALLOW_COMPILER_WARNINGS))
 CXXFLAGS += $(WARNINGS_AS_ERRORS)
 CFLAGS   += $(WARNINGS_AS_ERRORS)
-endif # CLANG_CL
-endif # FAIL_ON_WARNINGS
+endif # ALLOW_COMPILER_WARNINGS
 
 ifeq ($(OS_ARCH)_$(GNU_CC),WINNT_)
 #// Currently, unless USE_STATIC_LIBS is defined, the multithreaded

config/external/nss/moz.build

@@ -45,3 +45,6 @@ else:
         '/security/nss/lib/util/nssutil3',
         'sqlite',
     ]
+
+# XXX: We should fix these warnings.
+ALLOW_COMPILER_WARNINGS = True

config/gcc-stl-wrapper.template.h

@@ -17,11 +17,6 @@
 // Silence "warning: #include_next is a GCC extension"
 #pragma GCC system_header
 
-#ifdef _WIN32
-// Suppress windef.h min and max macros - they make std::min/max not compile.
-#define NOMINMAX 1
-#endif
-
 // Don't include mozalloc for cstdlib. See bug 1245076.
 #ifndef moz_dont_include_mozalloc_for_cstdlib
 #  define moz_dont_include_mozalloc_for_cstdlib

config/msvc-stl-wrapper.template.h

@@ -12,9 +12,6 @@
 #  error "STL code can only be used with -fno-exceptions"
 #endif
 
-// Suppress windef.h min and max macros - they make std::min/max not compile.
-#define NOMINMAX 1
-
 // Code built with !_HAS_EXCEPTIONS calls std::_Throw(), but the win2k
 // CRT doesn't export std::_Throw().  So we define it.
 #ifndef mozilla_Throw_h

configure.in

@@ -2301,6 +2301,8 @@ ia64*-hpux*)
     AC_DEFINE(HW_THREADS)
     AC_DEFINE(STDC_HEADERS)
     AC_DEFINE(WIN32_LEAN_AND_MEAN)
+    dnl See http://support.microsoft.com/kb/143208 to use STL
+    AC_DEFINE(NOMINMAX)
     TARGET_MD_ARCH=win32
     _PLATFORM_DEFAULT_TOOLKIT='cairo-windows'
     BIN_SUFFIX='.exe'

db/sqlite3/src/moz.build

@@ -9,6 +9,8 @@ EXPORTS += [
     'sqlite3.h',
 ]
 
+ALLOW_COMPILER_WARNINGS = True
+
 if CONFIG['MOZ_FOLD_LIBS']:
     # When folding libraries, sqlite is actually in the nss library.
     FINAL_LIBRARY = 'nss'

docshell/base/moz.build

@@ -64,8 +64,6 @@ UNIFIED_SOURCES += [
     'TimelineMarker.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

docshell/build/moz.build

@@ -24,5 +24,3 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
     LOCAL_INCLUDES += ['/uriloader/exthandler/mac']
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

docshell/shistory/src/moz.build

@@ -15,8 +15,6 @@ UNIFIED_SOURCES += [
     'nsSHTransaction.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/docshell/base',
 ]

dom/activities/moz.build

@@ -31,8 +31,6 @@ EXTRA_JS_MODULES += [
     'ActivitiesServiceFilter.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/alarm/moz.build

@@ -28,8 +28,6 @@ EXTRA_JS_MODULES += [
     'AlarmService.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/animation/moz.build

@@ -30,6 +30,4 @@ UNIFIED_SOURCES += [
     'PendingAnimationTracker.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/apps/moz.build

@@ -51,8 +51,6 @@ EXTRA_PP_JS_MODULES += [
     'Webapps.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 LOCAL_INCLUDES += [

dom/archivereader/moz.build

@@ -21,8 +21,6 @@ UNIFIED_SOURCES += [
     'ArchiveZipFile.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
 ]

dom/asmjscache/moz.build

@@ -16,8 +16,6 @@ IPDL_SOURCES += [
     'PAsmJSCacheEntry.ipdl'
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/audiochannel/moz.build

@@ -21,8 +21,6 @@ UNIFIED_SOURCES += [
     'AudioChannelService.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/base/moz.build

@@ -401,8 +401,6 @@ EXTRA_JS_MODULES += [
     'IndexedDBHelper.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../battery',
     '../bluetooth',

dom/battery/moz.build

@@ -13,8 +13,6 @@ SOURCES += [
     'BatteryManager.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/bindings/moz.build

@@ -40,8 +40,6 @@ EXPORTS.mozilla.dom += [
     'UnionMember.h',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
     '/dom/battery',

dom/bluetooth/moz.build

@@ -199,8 +199,6 @@ else:
         'bluetooth2/ipc/PBluetoothRequest.ipdl',
     ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
     '../network',

dom/broadcastchannel/moz.build

@@ -29,4 +29,3 @@ MOCHITEST_CHROME_MANIFESTS += ['tests/chrome.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-FAIL_ON_WARNINGS = True

dom/browser-element/moz.build

@@ -32,8 +32,6 @@ EXTRA_JS_MODULES += [
     'BrowserElementPromptService.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../bluetooth',
     '/dom/html',

dom/cache/moz.build

@@ -87,8 +87,6 @@ LOCAL_INCLUDES += [
     '../workers',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 MOCHITEST_MANIFESTS += [

dom/camera/moz.build

@@ -61,8 +61,6 @@ else:
         'FallbackCameraManager.cpp',
     ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
 ]

dom/canvas/compiledtest/moz.build

@@ -11,8 +11,6 @@ GeckoCppUnitTests([
     'TestWebGLElementArrayCache',
 ])
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../',
 ]

dom/canvas/moz.build

@@ -141,8 +141,6 @@ LOCAL_INCLUDES += [
     '/js/xpconnect/wrappers',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/cellbroadcast/moz.build

@@ -35,6 +35,4 @@ IPDL_SOURCES += [
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/crypto/moz.build

@@ -19,8 +19,6 @@ UNIFIED_SOURCES += [
     'WebCryptoTask.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/datastore/moz.build

@@ -45,4 +45,3 @@ MOCHITEST_MANIFESTS += ['tests/mochitest.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-FAIL_ON_WARNINGS = True

dom/devicestorage/moz.build

@@ -30,8 +30,6 @@ IPDL_SOURCES += [
     'PDeviceStorageRequest.ipdl',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/encoding/moz.build

@@ -18,8 +18,6 @@ UNIFIED_SOURCES += [
     'TextEncoder.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '/intl/locale',

dom/events/moz.build

@@ -124,8 +124,6 @@ SOURCES += [
 if CONFIG['MOZ_WEBSPEECH']:
     UNIFIED_SOURCES += ['SpeechRecognitionError.cpp']
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/fetch/moz.build

@@ -44,7 +44,6 @@ LOCAL_INCLUDES += [
     '/netwerk/protocol/http',
 ]
 
-FAIL_ON_WARNINGS = True
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')

dom/filehandle/moz.build

@@ -26,8 +26,6 @@ UNIFIED_SOURCES += [
     'MutableFile.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 LOCAL_INCLUDES += [

dom/filesystem/moz.build

@@ -42,5 +42,5 @@ LOCAL_INCLUDES += [
     '/dom/base',
 ]
 
-if not CONFIG['CLANG_CXX']:
-    FAIL_ON_WARNINGS = True
+if CONFIG['CLANG_CXX']:
+    ALLOW_COMPILER_WARNINGS = True

dom/fmradio/ipc/moz.build

@@ -18,8 +18,6 @@ UNIFIED_SOURCES += [
     'FMRadioRequestParent.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/fmradio/moz.build

@@ -27,8 +27,6 @@ IPDL_SOURCES += [
     'ipc/PFMRadioRequest.ipdl',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
     '../system/gonk',

dom/gamepad/moz.build

@@ -43,8 +43,6 @@ elif CONFIG['MOZ_GAMEPAD_BACKEND'] == 'android':
         'android/AndroidGamepad.cpp'
     ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/geolocation/moz.build

@@ -21,8 +21,6 @@ UNIFIED_SOURCES += [
     'nsGeoPosition.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/html/moz.build

@@ -226,8 +226,6 @@ EXTRA_COMPONENTS += [
     'htmlMenuBuilder.manifest'
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 LOCAL_INCLUDES += [

dom/icc/moz.build

@@ -48,8 +48,6 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']:
         'gonk/StkCmdFactory.manifest'
     ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/indexedDB/moz.build

@@ -87,8 +87,6 @@ include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/db/sqlite3/src',
     '/dom/base',

dom/inputport/moz.build

@@ -44,5 +44,3 @@ XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/ipc/ContentChild.cpp

@@ -605,7 +605,6 @@ ContentChild::Init(MessageLoop* aIOLoop,
                    IPC::Channel* aChannel)
 {
 #ifdef MOZ_WIDGET_GTK
-    // sigh
     gtk_init(nullptr, nullptr);
 #endif
 

dom/ipc/moz.build

@@ -105,8 +105,6 @@ IPDL_SOURCES += [
     'PTabContext.ipdlh',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/json/moz.build

@@ -12,8 +12,6 @@ UNIFIED_SOURCES += [
     'nsJSON.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/jsurl/moz.build

@@ -12,8 +12,6 @@ UNIFIED_SOURCES += [
     'nsJSProtocolHandler.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     "/dom/base",
     "/netwerk/base",

dom/mathml/moz.build

@@ -9,8 +9,6 @@ UNIFIED_SOURCES += [
     'nsMathMLElementFactory.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/media/android/moz.build

@@ -25,5 +25,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/apple/moz.build

@@ -14,8 +14,6 @@ UNIFIED_SOURCES += [
     'AppleMP3Reader.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 OS_LIBS += ['-framework AudioToolbox']

dom/media/bridge/moz.build

@@ -26,5 +26,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/directshow/moz.build

@@ -35,8 +35,6 @@ if not CONFIG['MOZ_WEBRTC']:
         '/media/webrtc/trunk/webrtc/modules/video_capture/windows/MediaType.cpp',
     ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '/media/webrtc/trunk/webrtc/modules/video_capture/windows',

dom/media/encoder/fmp4_muxer/moz.build

@@ -18,6 +18,4 @@ UNIFIED_SOURCES += [
     'MP4ESDS.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/media/encoder/moz.build

@@ -38,8 +38,6 @@ if CONFIG['MOZ_WEBM_ENCODER']:
     ]
     LOCAL_INCLUDES += ['/media/libyuv/include']
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 # These includes are from Android JB, for use of MediaCodec.

dom/media/fmp4/moz.build

@@ -23,7 +23,5 @@ SOURCES += [
 
 FINAL_LIBRARY = 'xul'
 
-FAIL_ON_WARNINGS = True
-
 if CONFIG['OS_ARCH'] == 'WINNT':
     DEFINES['NOMINMAX'] = True

dom/media/gmp-plugin-openh264/moz.build

@@ -22,5 +22,3 @@ USE_STATIC_LIBS = True
 NO_VISIBILITY_FLAGS = True
 # Don't use STL wrappers; this isn't Gecko code
 DISABLE_STL_WRAPPING = True
-
-FAIL_ON_WARNINGS = True

dom/media/gmp-plugin/moz.build

@@ -24,5 +24,3 @@ USE_STATIC_LIBS = True
 NO_VISIBILITY_FLAGS = True
 # Don't use STL wrappers; this isn't Gecko code
 DISABLE_STL_WRAPPING = True
-
-FAIL_ON_WARNINGS = True

dom/media/gmp/moz.build

@@ -133,8 +133,6 @@ if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
 # comment this out to use Unsafe Shmem for more performance
 DEFINES['GMP_SAFE_SHMEM'] = True
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/media/gmp/rlz/moz.build

@@ -20,5 +20,5 @@ LOCAL_INCLUDES += [
     '..',
 ]
 
-if CONFIG['GNU_CXX']:
-    FAIL_ON_WARNINGS = True
+if not CONFIG['GNU_CXX']:
+    ALLOW_COMPILER_WARNINGS = True

dom/media/gtest/moz.build

@@ -50,5 +50,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul-gtest'
-
-FAIL_ON_WARNINGS = True

dom/media/imagecapture/moz.build

@@ -14,5 +14,3 @@ UNIFIED_SOURCES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/mediasource/moz.build

@@ -36,6 +36,4 @@ UNIFIED_SOURCES += [
     'TrackBuffersManager.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/media/moz.build

@@ -280,8 +280,6 @@ EXTRA_JS_MODULES.media += [
     'RTCStatsReport.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/caps',
     '/dom/base',

dom/media/ogg/moz.build

@@ -20,6 +20,4 @@ UNIFIED_SOURCES += [
     'OpusParser.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/media/omx/moz.build

@@ -114,5 +114,3 @@ CXXFLAGS += [
 
 if CONFIG['ANDROID_VERSION'] > '15':
     DEFINES['MOZ_OMX_WEBM_DECODER'] = True
-
-FAIL_ON_WARNINGS = True

dom/media/platforms/agnostic/gmp/moz.build

@@ -22,5 +22,3 @@ UNIFIED_SOURCES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/platforms/ffmpeg/libav53/moz.build

@@ -21,5 +21,3 @@ if CONFIG['CLANG_CXX']:
   ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/platforms/ffmpeg/libav54/moz.build

@@ -21,5 +21,3 @@ if CONFIG['CLANG_CXX']:
   ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/platforms/ffmpeg/libav55/moz.build

@@ -23,5 +23,3 @@ if CONFIG['CLANG_CXX']:
   ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True