Merge pull request #17780 from SimonBrandner/fix/space-shortcut-local/17776

Fix space shortcuts on layouts with non-English keys in the places of numbers
pull/18053/head
Michael Telatynski 1 year ago committed by GitHub
commit 2635fc95f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 28
      src/vector/platform/ElectronPlatform.tsx

@ -589,24 +589,18 @@ export default class ElectronPlatform extends VectorBasePlatform {
handled = true;
}
break;
}
case "1":
case "2":
case "3":
case "4":
case "5":
case "6":
case "7":
case "8":
case "9":
case "0":
// ideally we would use SpaceStore.spacesEnabled here but importing SpaceStore in this platform
// breaks skinning as the platform is instantiated prior to the skin being loaded
if (SettingsStore.getValue("feature_spaces") && isOnlyCtrlOrCmdKeyEvent(ev)) {
this.navigateToSpace(parseInt(ev.key, 10));
handled = true;
}
break;
if (!handled &&
// ideally we would use SpaceStore.spacesEnabled here but importing SpaceStore in this platform
// breaks skinning as the platform is instantiated prior to the skin being loaded
SettingsStore.getValue("feature_spaces") &&
ev.code.startsWith("Digit") &&
isOnlyCtrlOrCmdKeyEvent(ev)
) {
const spaceNumber = ev.code.slice(5); // Cut off the first 5 characters - "Digit"
this.navigateToSpace(parseInt(spaceNumber, 10));
handled = true;
}
return handled;

Loading…
Cancel
Save