Move multi-repo linking to workflow section

pull/12730/head
J. Ryan Stinnett 2 years ago
parent 1aecc3d7e5
commit bd8b3a9046
  1. 6
      docs/review.md

@ -37,12 +37,12 @@ When reviewing code, here are some things we look for and also things we avoid:
* Take the time to thank and point out good code changes
* Using softer language like "please" and "what do you think?" goes a long way
towards making others feel like colleagues working towards a common goal
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.
### Workflow
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.
* Avoid force pushing to a PR after first round of review
* Use merge commits when landing
* PR author merges after review (assuming they have write access)

Loading…
Cancel
Save